-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: facebook photos page scroll #60
Open
Chickensoupwithrice
wants to merge
7
commits into
main
Choose a base branch
from
facebook-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 13, 2023 23:13
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 02:57
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 02:57
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 03:19
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 03:19
— with
GitHub Actions
Failure
We now track the first photo clicked, and stop once that one is found again
Chickensoupwithrice
force-pushed
the
facebook-fixes
branch
from
September 14, 2023 03:20
2d51cab
to
9ebc18d
Compare
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 03:20
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 03:20
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 17:45
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 17:45
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 19:47
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 19:47
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 21:58
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 22:06
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 22:48
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 14, 2023 23:24
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 15, 2023 19:02
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 15, 2023 19:06
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 15, 2023 19:12
— with
GitHub Actions
Failure
Chickensoupwithrice
had a problem deploying
to
DigitalOcean
September 19, 2023 22:39
— with
GitHub Actions
Failure
The test fails because the profile saved in the DO Space has been logged out of facebook. I've uploaded a new profile to |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Facebook changed the XPath for selecting the first image in the
photos
page, which with this PR gets autopilot going again. However, because the photos list wraps around (clicking next enough times will get you back to the start) there's no real end condition for this behaviour...Also in my tests I came across various different URL formats for photos pages depending on the source. They often don't match the regex we're looking for, which means the behaviour gets skipped. This PR doesn't deal with that case