Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: facebook photos page scroll #60

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Chickensoupwithrice
Copy link
Contributor

@Chickensoupwithrice Chickensoupwithrice commented Sep 13, 2023

Fixes #59

Facebook changed the XPath for selecting the first image in the photos page, which with this PR gets autopilot going again. However, because the photos list wraps around (clicking next enough times will get you back to the start) there's no real end condition for this behaviour...

Also in my tests I came across various different URL formats for photos pages depending on the source. They often don't match the regex we're looking for, which means the behaviour gets skipped. This PR doesn't deal with that case

We now track the first photo clicked, and stop once that one is found
again
@Chickensoupwithrice
Copy link
Contributor Author

The test fails because the profile saved in the DO Space has been logged out of facebook. I've uploaded a new profile to s3://dh-preserve/test-profiles/facebook/profile.tar.gz which only includes the sample logged in facebook account, but I'll need someone with permissions to the settings page in this repo to add it as a secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behavior Bug: Facebook behavior not working
1 participant