Update Angular workspace types and add update script #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! Tried the Bash script, flawless. We could rewrite to TS, but personally I really don't mind Bash. LFG. |
commit: |
webpro
reviewed
Dec 2, 2024
|
Thanks a lot David, very grateful for this 🙏 |
|
🚀 This pull request is included in v5.38.4. See Release 5.38.4 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems Angular CLI workspace file
angular.jsontypes has been updated with some additions around. This adds the new types using the samejson-schema-to-typescriptapproach.Adds a small shell script to help updating that file in the future. Let me know if JS is preffered. I'm more used to writing shell scripts, but can give try writing one using Node.js /
bun's compatiblechild_process.exec