Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip indexing into a gh action if its not an array #827

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

butlerx
Copy link
Contributor

@butlerx butlerx commented Nov 1, 2024

Skip checking a github action step if its not an array as its possibly a templated string.
In gh actions a valid config is ${{ toJSON(steps) }} which breaks the plugins parsing. if we see a string we should just skip those steps

Copy link

pkg-pr-new bot commented Nov 1, 2024

Open in Stackblitz

bun add https://pkg.pr.new/knip@827

commit: 23bf22c

@webpro
Copy link
Collaborator

webpro commented Nov 1, 2024

Thanks @butlerx! Should be out shortly.

@webpro webpro merged commit 0447003 into webpro-nl:main Nov 1, 2024
23 checks passed
@webpro
Copy link
Collaborator

webpro commented Nov 1, 2024

🚀 This pull request is included in v5.36.1. See Release 5.36.1 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants