Fix type output for unreferenced ns types

webpro-nl · Oct 7, 2022 · 76b0309 · 76b0309
1 parent 58bd222
commit 76b0309
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -85,7 +85,7 @@ export async function run(configuration: Configuration) {
       if (include.duplicates) {
         const duplicateExports = findDuplicateExportedNames(sourceFile);
         duplicateExports.forEach(symbols => {
-          const symbol = symbols.join(',');
+          const symbol = symbols.join('|');
           addIssue('duplicates', { filePath, symbol, symbols });
         });
       }
@@ -145,7 +145,7 @@ export async function run(configuration: Configuration) {
                 // No more reasons left to think this identifier is used somewhere else, report it as unreferenced
                 if (findReferencingNamespaceNodes(sourceFile).length > 0) {
                   if (type) {
-                    addIssue('nsTypes', { filePath, symbol: identifierText });
+                    addIssue('nsTypes', { filePath, symbol: identifierText, symbolType: type });
                   } else {
                     addIssue('nsExports', { filePath, symbol: identifierText });
                   }

diff --git a/src/reporters/symbols.ts b/src/reporters/symbols.ts
@@ -2,8 +2,9 @@ import path from 'node:path';
 import type { Issue, Issues, Configuration } from '../types';
 
 const logIssueLine = ({ issue, cwd, padding }: { issue: Issue; cwd: string; padding: number }) => {
+  const symbols = issue.symbols ? issue.symbols.join(', ') : issue.symbol;
   console.log(
-    `${issue.symbol.padEnd(padding + 2)}${issue.symbolType?.padEnd(11) || ''}${path.relative(cwd, issue.filePath)}`
+    `${symbols.padEnd(padding + 2)}${issue.symbolType?.padEnd(11) || ''}${path.relative(cwd, issue.filePath)}`
   );
 };
 
@@ -52,7 +53,7 @@ export default ({ issues, config, cwd }: { issues: Issues; config: Configuration
   }
 
   if (include.nsTypes) {
-    const unreferencedNsTypes = Object.values(issues.nsExports).map(Object.values).flat();
+    const unreferencedNsTypes = Object.values(issues.nsTypes).map(Object.values).flat();
     logIssueGroupResults(unreferencedNsTypes, cwd, reportMultipleGroups && 'UNUSED TYPES IN NAMESPACE');
   }
 

diff --git a/test/index.spec.ts b/test/index.spec.ts
@@ -33,5 +33,5 @@ test('run', async () => {
 
   assert(counters.duplicates === 1);
   assert(Object.values(issues.duplicates).length === 1);
-  assert(issues.duplicates['dep.ts']['dep,default'].symbols?.[0] === 'dep');
+  assert(issues.duplicates['dep.ts']['dep|default'].symbols?.[0] === 'dep');
 });