enable markdownlint for mdx #6446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chenxsan
commented
Oct 11, 2022
| "MD026": false, | ||
| "MD029": { "style": "ordered" }, | ||
| "MD033": false, | ||
| "MD034": false, | ||
| "MD036": false, | ||
| "MD041": false, | ||
| "MD053": false, |
There was a problem hiding this comment.
This one is disabled for temporary because of DavidAnson/markdownlint#571
snitin315
previously approved these changes
Oct 11, 2022
.markdownlintignore
Outdated
Comment on lines
1
to
2
| .vale/**/*.md | ||
| .github/**/*.md |
There was a problem hiding this comment.
Suggested change
| .vale/**/*.md | |
| .github/**/*.md | |
| .vale | |
| .github |
doesn't markdownlint lint only markdown files? we might not actually need *.md here? we can just add both directories alone?
There was a problem hiding this comment.
yeah, it's sort of superfluous. Actually I notice there's no .md files under .vale now, and we should apply rules to .github directory as well.
harish-sethuraman
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can catch errors like #6441 (comment)