Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor - remove typo extra underscore #6358

Merged
merged 2 commits into from
Aug 31, 2022
Merged

minor - remove typo extra underscore #6358

merged 2 commits into from
Aug 31, 2022

Conversation

peilingjiang
Copy link
Contributor

Remove an extra underscore in the documentation.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 29, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: peilingjiang / name: Peiling Jiang (e483d23)

@vercel
Copy link

vercel bot commented Aug 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webpack-js-org ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 4:52PM (UTC)

chenxsan
chenxsan reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks there's another one on line 1504:

  //Test Comment
  else root['MyLibrary'] = factory();
})(self, function () {
  return __entry_return_;
});

Could u update it too?

@peilingjiang peilingjiang requested a review from chenxsan August 31, 2022 02:10
chenxsan
chenxsan approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@chenxsan chenxsan merged commit db5dcd2 into webpack:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxsan chenxsan chenxsan approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peilingjiang @chenxsan