Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type description for ctx.contextInfo for externals callback #6340

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Fix type description for ctx.contextInfo for externals callback #6340

merged 1 commit into from
Aug 18, 2022

Conversation

huozhi
Copy link
Contributor

@huozhi huozhi commented Aug 18, 2022 •
edited
Loading

Fix the type declaration for ctx.contextinfo in externals handling callback

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

@vercel
Copy link

vercel bot commented Aug 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webpack-js-org ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 11:36AM (UTC)

@huozhi huozhi changed the title Fix type for ctx.contextInfo Fix type description for ctx.contextInfo for externals callback Aug 18, 2022
chenxsan
chenxsan approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@chenxsan chenxsan merged commit a0c12be into webpack:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxsan chenxsan chenxsan approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huozhi @chenxsan