Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix highlighting for current subnav #6240

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

chenxsan
Copy link
Member

@chenxsan chenxsan commented Jun 25, 2022

CleanShot 2022-06-25 at 11 45 53@2x

The subnav item should be highlighted when we are visiting its child sections.

@vercel
Copy link

vercel bot commented Jun 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webpack-js-org ✅ Ready (Inspect) Visit Preview Jun 25, 2022 at 3:45AM (UTC)

@chenxsan chenxsan marked this pull request as ready for review June 25, 2022 03:51
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315 snitin315 merged commit 3e4dcec into webpack:master Jun 26, 2022
@chenxsan chenxsan deleted the bugfix/highlight-sub-navbar branch June 26, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants