-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch readme.md as mdx #5298
Merged
Merged
fetch readme.md as mdx #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/7ga4eySAiAkbnuBHCV28gBBQbYaK |
6 tasks
6 tasks
This reverts commit 557e4e9.
6 tasks
This reverts commit 23cf1bb.
This reverts commit f673c88.
This reverts commit e95b09f.
snitin315
approved these changes
Aug 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're two types of contents in this repository:
src/content
which we can usemdx
safelyreadme.md
file hosted on github, e.g.,webpack-contrib/css-loader
This pull request is an attempt to handling the second type as
mdx
. It might not work as I expected, which means we'll have to maintain both.md
and.mdx
on this repository.img
elementreadme.md
files.Btw, we're leaving those
md
related configuration at the moment as the downstream repositories might have their ownmd
files, e.g., https://github.com/docschina/webpack.js.org/blob/cn/src/content/plugins/terser-webpack-plugin.md. I'll eliminate thosemd
related configuration in near future.clean up
div[align='center']
Unfortunately the original regular expression for cleaning up
div[align='center']
is defective, it can't handle a nested one:Thus I'm turning to a remark plugin to resolve it.