Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugins) document ProvidePlugin #3102

Merged
merged 3 commits into from
Jun 14, 2019
Merged

docs(plugins) document ProvidePlugin #3102

merged 3 commits into from
Jun 14, 2019

Conversation

EugeneHlushko
Copy link
Member

Document ProvidePlugin

FIxes #3094

@netlify
Copy link

netlify bot commented Jun 6, 2019

Preview is ready

Built with commit 0a1810b

https://deploy-preview-3102--webpackjsorg-netlify.netlify.com


- `percentage`: a number between 0 and 1 indicating the completion percentage of the compilation
- `message`: a short description of the currently-executing hook
- `...args`: zero or more additional strings describing the current progress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zero or more additional strings

That doesn't say anything haha, What is it exactly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅
Yes unfortunately source code doesn't have them used. I think it's reserved to avoid breaking changes in future when plugin is changed

@montogeek montogeek merged commit 3ad6ca2 into master Jun 14, 2019
@montogeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProgressPlugin Documentation: Many options missing
2 participants