Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing invalid splitChunks example #2478

Merged
merged 2 commits into from
Sep 2, 2018
Merged

fixing invalid splitChunks example #2478

merged 2 commits into from
Sep 2, 2018

Conversation

chrisdothtml
Copy link
Member

From this comment:

The documentation (https://webpack.js.org/plugins/split-chunks-plugin/#splitchunks-cachegroups-test) shows a code example defining splitChunks.test (which I dont believe exists?) instead of splitChunks.cacheGroups[yourGroup].test.

EugeneHlushko
EugeneHlushko approved these changes Sep 2, 2018
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@montogeek montogeek merged commit 859a2c6 into webpack:master Sep 2, 2018
@montogeek
Copy link
Member

Thanks!

@chrisdothtml chrisdothtml deleted the bugfix/splitchunks-typo branch February 27, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees
No one assigned
Labels
Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdothtml @montogeek @EugeneHlushko