-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA] rename components and move app specific code to /src #1490
Changes from all commits
d1aca6a
e5dc364
03438d1
b0d00ee
5e25b8a
b301ce0
7d53fd5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import React from 'react'; | ||
import Link from '../link/link'; | ||
import Container from '../container/container'; | ||
import Link from '../Link/Link'; | ||
import Container from '../Container/Container'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now that each file is named similarly just with a different extension, is there a potential for conflict here? Seeing as the site works, I'm guessing webpack tries There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok still interested in thoughts on this ambiguity but as far as I can tell this isn't causing any issues. |
||
import Icon from '../../assets/icon-square-small.svg'; | ||
import CC from '../../assets/cc.svg'; | ||
import BY from '../../assets/by.svg'; | ||
import './footer-style'; | ||
import './Footer.scss'; | ||
|
||
export default (props) => { | ||
return ( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to keep the
/scripts
directory as is seeing as it's not part of the actual site code. @bebraw what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'm going to leave this for now but may revert this change in a follow up PR. It's nothing major but I think it's good to separate build process related scripts from actual the actual javascript that runs the site (though the line is somewhat blurry for static site generators).