Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use url.format to generate URI #644

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Use url.format to generate URI #644

merged 2 commits into from
Oct 11, 2016

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Oct 10, 2016

Please check if the PR fulfills these requirements

  • An example has been added or updated in examples/ (for features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • [ x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:

This supports ipv6 ip addresses.

This supports ipv6 ip addresses.
Copy link
Member

@SpaceK33z SpaceK33z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the examples (in examples/) don't work anymore. I tested examples/modus-inline, and the displayed uri was "http:".

@graingert
Copy link
Contributor Author

That's strange, what data is going into url.format that results in the failure?

@SpaceK33z
Copy link
Member

SpaceK33z commented Oct 11, 2016

The data going into it is:

{ protocol: 'http',
  hostName: 'localhost',
  port: '8080',
  pathName: '/' }

You can test this by navigating to examples/modus-inline, the instructions are in the readme there ;).

According to the node.js documentation you're using some wrong parameter keys it seems.

Copy link
Member

@SpaceK33z SpaceK33z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@SpaceK33z SpaceK33z merged commit b75ca49 into webpack:master Oct 11, 2016
@SpaceK33z SpaceK33z mentioned this pull request Oct 11, 2016
@graingert graingert deleted the patch-2 branch October 11, 2016 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants