feat: allow to set the sockjs_url option (only sockjs)
#4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested review from
hiroppy,
snitin315 and
anshumanv
as code owners
Codecov ReportBase: 90.48% // Head: 91.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4586 +/- ##
==========================================
+ Coverage 90.48% 91.96% +1.48%
==========================================
Files 16 16
Lines 1639 1655 +16
Branches 617 622 +5
==========================================
+ Hits 1483 1522 +39
+ Misses 142 122 -20
+ Partials 14 11 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
snitin315
approved these changes
Sep 27, 2022
|
Yeah feel fre to update our docs 👍 And thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
To test it we should disable websocket supporting in headless chrome (but it is impossible), as an alternative solution we can allow to set all options for sockjs server, but sockjs is old and only for old IE and Opera, I don't think many developers support it now and we should spend time on it, really, so I tested it manually and all works fine, in the next major release we will remove sockjs
Motivation / Use-Case
fixes #4348
Breaking Changes
No
Additional Info
Should we document it?