Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gracefully and force shutdown #3880

Merged
merged 4 commits into from
Sep 24, 2021
Merged

feat: gracefully and force shutdown #3880

merged 4 commits into from
Sep 24, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 24, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

manually

Motivation / Use-Case

fixes #1479

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #3880 (d739ceb) into master (01b178d) will decrease coverage by 0.08%.
The diff coverage is 79.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3880      +/-   ##
==========================================
- Coverage   92.72%   92.63%   -0.09%     
==========================================
  Files          14       14              
  Lines        1334     1345      +11     
  Branches      467      467              
==========================================
+ Hits         1237     1246       +9     
- Misses         89       92       +3     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
client-src/index.js 80.76% <71.42%> (-0.61%) ⬇️
lib/Server.js 93.60% <90.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0dbea0...d739ceb. Read the comment docs.

@alexander-akait alexander-akait merged commit db24b16 into master Sep 24, 2021
@alexander-akait alexander-akait deleted the issue-1479 branch September 24, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't close webpack-dev-server --progress with Ctrl + C
1 participant