-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display file name in overlay #3867
Conversation
|
Please update tests |
b2c7b7b
to
ef089e8
Compare
should I add test for it or just fix the lint? |
Both, CI should be all green. |
Codecov Report
@@ Coverage Diff @@
## master #3867 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 14 14
Lines 1334 1334
Branches 467 467
=======================================
Hits 1237 1237
Misses 89 89
Partials 8 8 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a test case for this in https://github.com/webpack/webpack-dev-server/blob/master/test/e2e/overlay.test.js
@snitin315 Yep, I think we can merge it, I will send test cases today, maybe we need more fields here |
For Bugs and Features; did you add new tests?
since there is no test for overlayer yet, so I did not add test for it
Motivation / Use-Case
we are not display filename in webpack5 for error now
compare to error ovelay in webpack-dev-server V3
Breaking Changes
no
Additional Info
add filename for error