Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to nanocolors #3865

Merged
merged 2 commits into from
Sep 24, 2021
Merged

chore: migrate to nanocolors #3865

merged 2 commits into from
Sep 24, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Update to colorette v2

options.enabled was removed.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #3865 (07fa1e4) into master (4962424) will increase coverage by 1.64%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3865      +/-   ##
==========================================
+ Coverage   91.07%   92.72%   +1.64%     
==========================================
  Files          14       14              
  Lines        1334     1334              
  Branches      467      467              
==========================================
+ Hits         1215     1237      +22     
+ Misses        108       89      -19     
+ Partials       11        8       -3     
Impacted Files Coverage Δ
lib/Server.js 93.64% <75.00%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4962424...07fa1e4. Read the comment docs.

@snitin315
Copy link
Member Author

/cc @alexander-akait

@alexander-akait
Copy link
Member

I will look at this today 👍 Also on other comments

@alexander-akait
Copy link
Member

@snitin315 Let's migrate on https://github.com/ai/nanocolors, for webpack-cli and webpack-dev-middleware

@snitin315
Copy link
Member Author

I will migrate 👍

@snitin315
Copy link
Member Author

Should we migrate to nanocolors here too?

@alexander-akait
Copy link
Member

@snitin315 Yes

@snitin315 snitin315 changed the title chore: migrate to colorette v2 chore: migrate to nanocolors Sep 24, 2021
@alexander-akait alexander-akait merged commit 01b178d into master Sep 24, 2021
@alexander-akait alexander-akait deleted the update-coloretter branch September 24, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants