Fix websocket connection for non-inlined scripts #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can verify that this fixes #326. Please merge 😄 |
sokra
added a commit
that referenced
this pull request
Dec 3, 2015
Fix websocket connection for non-inlined scripts
|
Thanks |
|
Can we create a new release with this fix because the current release is broken? |
|
👍 for a new release |
|
Appreciate a release, the current version has been broken for 23 days! |
|
@sokra thoughts on a new patch release? |
|
@sokra, could you please release a new version with this fix? The current version is completely broken if you don't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my previous PR, #302, I broke the websocket connection for scripts that are not using the
--inlineoption.Fixes #326.