Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more https option related cli flags #3241

Merged
merged 10 commits into from
May 6, 2021
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 2, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yep WIP

Motivation / Use-Case

Fixes #2996

Allow following flags -

  • --https-passphrase <value>
  • --https-key <value>
  • --https-pfx <value>
  • --https-cert <value>
  • --https-cacert <value>
  • --https-request-cert
  • --no-https-request-cert

Breaking Changes

None

Additional Info

No

@snitin315 snitin315 mentioned this pull request May 2, 2021
6 tasks
@snitin315 snitin315 marked this pull request as ready for review May 5, 2021 15:17
@snitin315 snitin315 changed the title [WIP]feat: add more https option related cli flags feat: add more https option related cli flags May 5, 2021
alexander-akait
alexander-akait previously approved these changes May 5, 2021
anshumanv
anshumanv previously approved these changes May 5, 2021
@snitin315 snitin315 dismissed stale reviews from anshumanv and alexander-akait via 984970e May 6, 2021 01:27
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #3241 (8769e1a) into master (e664b3b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3241   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          34       34           
  Lines        1231     1231           
  Branches      346      346           
=======================================
  Hits         1174     1174           
  Misses         51       51           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e664b3b...8769e1a. Read the comment docs.

@alexander-akait alexander-akait merged commit f4f4b45 into master May 6, 2021
@alexander-akait alexander-akait deleted the https-flags branch May 6, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack5: devserver does not work with --cacert CLI option
3 participants