Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor #3150

Merged
merged 4 commits into from
Apr 6, 2021
Merged

test: refactor #3150

merged 4 commits into from
Apr 6, 2021

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

NA

Motivation / Use-Case

removes dup tests

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #3150 (bdcf41b) into master (e07a5d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3150   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          37       37           
  Lines        1218     1218           
  Branches      338      338           
=======================================
  Hits         1157     1157           
  Misses         55       55           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07a5d7...bdcf41b. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix CI

@anshumanv
Copy link
Member Author

hmm macos CI strange

@anshumanv anshumanv requested a review from snitin315 April 6, 2021 13:01
snitin315
snitin315 previously approved these changes Apr 6, 2021
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexander-akait
Copy link
Member

Need small improve WIP

@alexander-akait
Copy link
Member

I really hate macos on github actions...

@alexander-akait alexander-akait merged commit ad3db67 into master Apr 6, 2021
@alexander-akait alexander-akait deleted the ref/test branch April 6, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants