Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if serverData object exist #2501

Closed
wants to merge 1 commit into from

Conversation

jeffin143
Copy link

@jeffin143 jeffin143 commented Apr 3, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

#1479 (comment)

This is just a minor patch

Breaking Changes

None

Additional Info

Nothing

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #2501 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2501   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files          34       34           
  Lines        1325     1325           
  Branches      381      381           
=======================================
  Hits         1240     1240           
  Misses         83       83           
  Partials        2        2           
Impacted Files Coverage Δ
lib/utils/setupExitSignals.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4808abd...10992bf. Read the comment docs.

@hiroppy
Copy link
Member

hiroppy commented Apr 5, 2020

This is an internal function and this argument always exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants