Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix ProvidePlugin.test.js #2002

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

knagaitsev
Copy link
Collaborator

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Updated ProvidePlugin.test.js

Motivation / Use-Case

We need to provide the compiled version of the client in order for injectedClient === expectedClient to be true.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #2002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2002   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          28       28           
  Lines        1083     1083           
  Branches      324      324           
=======================================
  Hits         1002     1002           
  Misses         77       77           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce81c69...10782d9. Read the comment docs.

@alexander-akait alexander-akait merged commit 47453cb into webpack:master Jun 10, 2019
@knagaitsev knagaitsev added gsoc Google Summer of Code scope: ws(s) labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Google Summer of Code scope: ws(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants