Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(regression): host and port can be undefined or null #1779

Merged
merged 1 commit into from
Apr 9, 2019
Merged

fix(regression): host and port can be undefined or null #1779

merged 1 commit into from
Apr 9, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes, many

Motivation / Use-Case

Previously we allow host and port to be null/undefined

Breaking Changes

No

Additional Info

No

@alexander-akait alexander-akait requested a review from hiroppy as a code owner April 9, 2019 13:03
@alexander-akait alexander-akait force-pushed the fix(regression)-host-and-port-can-be-undefined-or-null branch from 9f19116 to 229ec96 Compare April 9, 2019 14:16
@codecov
Copy link

codecov bot commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #1779 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1779   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files           9        9           
  Lines         590      590           
  Branches      176      176           
=======================================
  Hits          517      517           
  Misses         61       61           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ea174...01fc990. Read the comment docs.

hiroppy
hiroppy approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests, LGTM

@alexander-akait alexander-akait force-pushed the fix(regression)-host-and-port-can-be-undefined-or-null branch from 229ec96 to 01fc990 Compare April 9, 2019 14:32
@alexander-akait alexander-akait merged commit 028ceee into master Apr 9, 2019
@alexander-akait alexander-akait deleted the fix(regression)-host-and-port-can-be-undefined-or-null branch April 9, 2019 15:11
@snyk-bot snyk-bot mentioned this pull request Aug 30, 2019
Closed
@tonyg101 tonyg101 mentioned this pull request Mar 22, 2024
Open
@GerHobbelt GerHobbelt mentioned this pull request Mar 23, 2024
Open
This was referenced Mar 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-akait @hiroppy