update webpack-dev-middleware dependency to v3.1.3 #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexander-akait
requested changes
Apr 27, 2018
package.json
Outdated
| @@ -67,7 +67,7 @@ | |||
| "spdy": "^3.4.1", | |||
| "strip-ansi": "^3.0.0", | |||
| "supports-color": "^5.1.0", | |||
| "webpack-dev-middleware": "3.1.2", | |||
| "webpack-dev-middleware": "^3.1.3", | |||
There was a problem hiding this comment.
Thanks for PR, please don't change semver, it is can break build in future. I.E. remove ^
There was a problem hiding this comment.
yikes, didn't even realize I did that! sorry, corrected.
Codecov Report
@@ Coverage Diff @@
## master #1392 +/- ##
=======================================
Coverage 79.14% 79.14%
=======================================
Files 6 6
Lines 494 494
Branches 160 160
=======================================
Hits 391 391
Misses 103 103Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Apr 27, 2018
|
/cc @SpaceK33z |
|
hi @SpaceK33z any chance this can be merged? |
|
Sorry for the delay. |
|
cheers! no worries at all, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Use-Case
Spaces in the
outputPathare not being handled correctly on Windows.This change addresses the regression which introduced the bug and is being tracked in #1375
The only change made is that the
package.jsonhas been updated to reference v3.1.3 of webpack-dev-middleware.The issue was corrected here:
webpack/webpack-dev-middleware#297