Remove Tapable#apply calls #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceK33z
approved these changes
Mar 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #1331 +/- ##
=======================================
Coverage 79.14% 79.14%
=======================================
Files 6 6
Lines 494 494
Branches 160 160
=======================================
Hits 391 391
Misses 103 103
Continue to review full report at Codecov.
|
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
Tapable#applyis deprecated so I removed the calls.Breaking Changes
no
Additional Info
No more deprecation notice about
Tapable#apply