Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a small feature
Did you add or update the
examples/
?no
Summary
If you are doing server side rendering, by sending all HTML requests to a proxy, and your webpack config generates an
index.html
file, that file will get served instead of your server-side-rendered content for the root of the domain. Passing anindex
value offalse
to webpack-dev-middleware prevents it from serving the index file, but it violates the current schema for options passed into webpack dev server.Does this PR introduce a breaking change?
No, this merely allows an extra value to be passed in for an existing option.
Other information
You can work around this issue by passing in
''
which is close enough tofalse
to trigger the desired behaviour in webpack-dev-middleware, but also a string so it passes validation.