Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add https.cacert #3240

Merged
merged 1 commit into from
May 5, 2021
Merged

feat: add https.cacert #3240

merged 1 commit into from
May 5, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 2, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Updated existing tests.

Motivation / Use-Case

Refers #2996

Breaking Changes

BREAKING CHANGE: https.ca was removed

Additional Info

After this, I will finish #3241

BREAKING CHANGE: `https.ca` was removed
@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #3240 (94b8fc5) into master (e10c2a0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3240   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          34       34           
  Lines        1231     1231           
  Branches      346      346           
=======================================
  Hits         1174     1174           
  Misses         51       51           
  Partials        6        6           
Impacted Files Coverage Δ
lib/Server.js 95.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10c2a0...94b8fc5. Read the comment docs.

@alexander-akait alexander-akait merged commit b212a2c into master May 5, 2021
@alexander-akait alexander-akait deleted the https-cacert branch May 5, 2021 12:59
@govizlora govizlora mentioned this pull request Sep 8, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants