Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regression): host and port can be undefined or null #1779

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes, many

Motivation / Use-Case

Previously we allow host and port to be null/undefined

Breaking Changes

No

Additional Info

No

@alexander-akait alexander-akait force-pushed the fix(regression)-host-and-port-can-be-undefined-or-null branch from 9f19116 to 229ec96 Compare April 9, 2019 14:16
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #1779 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1779   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files           9        9           
  Lines         590      590           
  Branches      176      176           
=======================================
  Hits          517      517           
  Misses         61       61           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ea174...01fc990. Read the comment docs.

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants