Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set statusCode to 200 to capable of koa #94

Merged
merged 1 commit into from
Aug 21, 2016
Merged

Conversation

mofelee
Copy link
Contributor

@mofelee mofelee commented May 12, 2016

when I use koa to serve webpack-dev-middleware, it will always return 404

because this line
https://github.com/koajs/koa/blob/master/lib/application.js#L133

image
image
image

but body return normally(after rebuild assets, so url is different)
image

@mofelee
Copy link
Contributor Author

mofelee commented May 12, 2016

example code:

https://github.com/MofeLee/blog/blob/webpack-hot-middleware-example/webpack/webpack-dev-server.js

npm run dev

@SpaceK33z SpaceK33z merged commit 024ac8b into webpack:master Aug 21, 2016
@SpaceK33z
Copy link
Member

Thanks!

@Carrotzpc
Copy link

@SpaceK33z I encountered the same problem , please update the npm , thanks ~

@SpaceK33z
Copy link
Member

@Carrotzpc, I want to fix a few other things first, so you'll have to wait for a ~ week.

@Carrotzpc
Copy link

@SpaceK33z Well , I do a workaroud by koa-webpack-dev-middleware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants