Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for undefined statsOptions #813

Closed
wants to merge 2 commits into from
Closed

fix: account for undefined statsOptions #813

wants to merge 2 commits into from

Conversation

danielroe
Copy link

@danielroe danielroe commented Jan 12, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

I was getting Cannot read property 'colors' of undefined at this point in the built dev-middleware, which makes sense as it is possible for it to be undefined.

Reproduction: https://codesandbox.io/s/recursing-keller-b8g1s?file=/nuxt.config.js

Breaking Changes

Additional Info

@danielroe danielroe marked this pull request as ready for review January 12, 2021 21:41
@danielroe danielroe requested a review from hiroppy as a code owner January 12, 2021 21:41
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #813 (64346e7) into master (0d42f71) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   98.50%   98.51%           
=======================================
  Files          10       10           
  Lines         268      269    +1     
  Branches       93       94    +1     
=======================================
+ Hits          264      265    +1     
  Misses          4        4           
Impacted Files Coverage Δ
src/utils/setupHooks.js 98.00% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d42f71...64346e7. Read the comment docs.

pi0 added a commit to nuxt/nuxt that referenced this pull request Jan 13, 2021
@danielroe danielroe deleted the fix-statsOptions branch January 13, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants