Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): add chalk to peerDeps #292

Merged
merged 1 commit into from
Apr 5, 2018
Merged

fix(package): add chalk to peerDeps #292

merged 1 commit into from
Apr 5, 2018

Conversation

shellscape
Copy link
Contributor

@shellscape shellscape commented Apr 4, 2018

What kind of change does this PR introduce?

package.json change to fix an issue with chalk not being a peerDep

Did you add tests for your changes?

No need

Summary

peerDeps are like, so cool. Fixes #291

Does this PR introduce a breaking change?

No

Other information

@shellscape shellscape requested review from bebraw and joshwiens April 4, 2018 15:30
@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files           7        7           
  Lines         251      251           
=======================================
  Hits          243      243           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d53d7c...26dbbc9. Read the comment docs.

@shellscape shellscape merged commit cb82ac0 into master Apr 5, 2018
@shellscape shellscape deleted the fix/chalk-peer branch April 5, 2018 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

writeToDisk crashes if chalk isn't installed
2 participants