On windows path spaces should resolve to %20 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 97.2% 97.24% +0.03%
==========================================
Files 6 6
Lines 215 218 +3
==========================================
+ Hits 209 212 +3
Misses 6 6
Continue to review full report at Codecov.
|
|
You did not implement the %20 on the file system, it broke my pipeline.
|
|
@elios264 please submit a PR with a failing test case, or submit a PR with a fix. your comment doesn't contain any useful information. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
Yes
Summary
fixes #284, on windows path spaces should resolve to %20
Does this PR introduce a breaking change?
For implementations relying on the bug, possibly.
Other information
This PR is WIP until this line is removed, as changes will be pushed to the target branch for AppVeyor to compile, as I don't have access to Windows at the moment.