-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update middleware.js #281
Update middleware.js #281
Conversation
fix error TypeError: Cannot set property 'webpackStats' of undefined
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment!
@@ -14,6 +14,7 @@ module.exports = function wrapper(context) { | |||
|
|||
return new Promise(((resolve) => { | |||
ready(context, () => { | |||
res.locals = res.locals || {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link to any issue regarding this or fill a longer description of what you're trying to fix? Would help us understand your problem space, as this issue might be deeper than just setting a default. Thanks! ❤️
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=========================================
+ Coverage 97.19% 97.2% +0.01%
=========================================
Files 6 6
Lines 214 215 +1
=========================================
+ Hits 208 209 +1
Misses 6 6
Continue to review full report at Codecov.
|
PR template removed. Closing as invalid. |
Well, I was going to reopen this and merge it but the CLA wasn't signed so we can't. @cexoso I'm going to implement your fix and give you credit in the commit message. In the future it's important not to delete or alter issue and pull request templates. |
fix error TypeError: Cannot set property 'webpackStats' of undefined