Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update middleware.js #281

Closed
wants to merge 1 commit into from
Closed

Update middleware.js #281

wants to merge 1 commit into from

Conversation

cexoso
Copy link

@cexoso cexoso commented Mar 16, 2018

fix error TypeError: Cannot set property 'webpackStats' of undefined

fix error TypeError: Cannot set property 'webpackStats' of undefined
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment!

@@ -14,6 +14,7 @@ module.exports = function wrapper(context) {

return new Promise(((resolve) => {
ready(context, () => {
res.locals = res.locals || {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to any issue regarding this or fill a longer description of what you're trying to fix? Would help us understand your problem space, as this issue might be deeper than just setting a default. Thanks! ❤️

@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #281 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #281      +/-   ##
=========================================
+ Coverage   97.19%   97.2%   +0.01%     
=========================================
  Files           6       6              
  Lines         214     215       +1     
=========================================
+ Hits          208     209       +1     
  Misses          6       6
Impacted Files Coverage Δ
lib/middleware.js 94.11% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14de0b9...8d7009d. Read the comment docs.

@cexoso
Copy link
Author

cexoso commented Mar 16, 2018

#282

@shellscape
Copy link
Contributor

PR template removed. Closing as invalid.

@shellscape
Copy link
Contributor

Well, I was going to reopen this and merge it but the CLA wasn't signed so we can't. @cexoso I'm going to implement your fix and give you credit in the commit message. In the future it's important not to delete or alter issue and pull request templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants