Improve messages when bundle is compiling and done with compiling #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Change, a small improvement in DX.
Did you add tests for your changes?
Yes
Summary
When the bundle is compiling, the console showed this:
When it is done compiling, regardless of errors, it showed this:
This is very confusing, because most people think when it is "valid", that the bundle has successfully compiled. Also, when it says "bundle is now INVALID", people can think they have done something wrong.
This PR indents to clarify these messages;
When the bundle is compiling:
When the bundle is done compiling, but has errors:
When the bundle is done compiling, no errors:
Note that if there are warnings, it will say "Compiled successfully." This is because a bundle with warnings will still work. I could add a special case for this, maybe "Compiled successfully, but with warnings." ?
Does this PR introduce a breaking change?
Not really, but I think there might be people who have hacked something based on these messages.
Other information
Inspired by this discussion on Twitter. The messages are also stolen from create-react-app.
cc @gaearon