Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stats #127

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Expose stats #127

merged 2 commits into from
Sep 20, 2016

Conversation

egoist
Copy link
Contributor

@egoist egoist commented Sep 19, 2016

As discussed in #126

SpaceK33z
SpaceK33z requested changes Sep 19, 2016
View reviewed changes
Copy link
Member

@SpaceK33z SpaceK33z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this? Seems unnecessary for such a small addition, but if this is not done anyone could break it without the tests failing. Best place would be test/API.test.js.

@egoist
Copy link
Contributor Author

egoist commented Sep 20, 2016

Updated, I'm not sure if it's supposed to follow the (err, stats) style.

@SpaceK33z SpaceK33z merged commit d5e0e9b into webpack:master Sep 20, 2016
@SpaceK33z
Copy link
Member

Thanks!

@egoist egoist deleted the patch-1 branch September 20, 2016 08:19
@SpaceK33z SpaceK33z mentioned this pull request Sep 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceK33z SpaceK33z SpaceK33z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egoist @SpaceK33z