docs(contribute): adds table of contents and info about dependencies. #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
misterdev
suggested changes
Apr 21, 2019
misterdev
reviewed
Apr 21, 2019
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
misterdev
approved these changes
Apr 21, 2019
evenstensberg
approved these changes
Apr 21, 2019
dhruvdutt
approved these changes
Apr 21, 2019
ematipico
suggested changes
Apr 22, 2019
.github/CONTRIBUTING.md
Outdated
| - [Your first Contribution](#your-first-contribution) | ||
| - [Setup](#setup) | ||
| - [Using npm](#using-npm) | ||
| - [Using yarn](#using-yarn) |
There was a problem hiding this comment.
The indentation is not correct. Could you please check with prettier? Or an online linter? https://dlaa.me/markdownlint/
There was a problem hiding this comment.
Done, pls join the discussion on #850
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
pranshuchittora
force-pushed
the
docs-contribute
branch
from
60fb56c
to
dca8f74
Compare
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
pranshuchittora
force-pushed
the
docs-contribute
branch
from
dca8f74
to
73ed3c1
Compare
|
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
adds table of contents and adds some information about dependencies in the project
updates the table of contents based on review
fixes linting based on markdownlint
trying to resolve merge conflicts
pranshuchittora
force-pushed
the
docs-contribute
branch
from
73ed3c1
to
b09448c
Compare
akss13
approved these changes
Apr 22, 2019
rishabh3112
approved these changes
Apr 22, 2019
evenstensberg
approved these changes
Apr 22, 2019
ematipico
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Docs
Motivation
package-lock.json)Hence everything sorted 🎉