feat(generators): add typescript support #532

dhruvdutt · 2018-06-27T21:40:06Z

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Not ready for review yet.

evenstensberg

You'll need to go over this again and swap any with specific types. Did a first review but it's too much of any here to comment them all. Do a console.log(typeof thisVal) if you're insecure about the type of the values you're adding.

evenstensberg · 2018-06-28T15:30:26Z

packages/generators/add-generator.ts

-const webpackDevServerSchema = require("webpack-dev-server/lib/optionsSchema.json");
-const PROP_TYPES = require("@webpack-cli/utils/prop-types");
+import glob from "glob-all";
+import inquirerAutoComplete from "inquirer-autocomplete-prompt";


import autoComplete

evenstensberg · 2018-06-28T15:31:06Z

packages/generators/add-generator.ts

-		PROPS.filter(food =>
-			food.toLowerCase().includes(input.toLowerCase())
-		)
+		PROPS.filter((food: string) =>


Why is this named food? ^_^

evenstensberg · 2018-06-28T15:31:45Z

packages/generators/add-generator.ts

-		let manualOrListInput = action =>
-			Input("actionAnswer", `What do you want to add to ${action}?`);
+	public prompting() {
+		const done: any = this.async();


This is a promise that resolves to a boolean if I remember right

You mean something like?

const done: Promise<boolean>

Also, if it's a done is a promise, the compiler would fail all calls like done(). I think done is a function. Something like this should work:

const done: () => void | boolean

It's a promise http://yeoman.io/authoring/running-context.html

If the asynchronous API you’re relying upon doesn’t support promises, then you can rely on the legacy this.async() way. Calling this.async() will return a function to call once the task is done.

It's not a promise. It could be something like this:

const done: () => void | boolean

evenstensberg · 2018-06-28T15:32:21Z

packages/generators/add-generator.ts


 		// first index indicates if it has a deep prop, 2nd indicates what kind of
-		let isDeepProp = [false, false];
+		const isDeepProp: any[] = [false, false];


a bit naive to use any here when you can see the type

Yeah. I tried boolean[] and Array<object | boolean> but both won't work because we also assign the values as boolean, string, object, array in different scopes. Some of the examples:

webpack-cli/packages/generators/add-generator.js

Line 412 in 51dc005

isDeepProp[1] = answerToAction.actionAnswer;

webpack-cli/packages/generators/add-generator.js

Line 443 in 51dc005

if (isDeepProp[2].length === 0) {

https://stackoverflow.com/questions/40914716/dynamic-typescript-typing

const isDeepProp: [boolean, string | boolean | object | object[]]

^This is a valid type declaration which allows to control specifically which element should be of which type. Even after declaring the second element to be one of the boolean, string, object or array of objects, the compiler fails. I think the complex reassignment logic we're doing inside the generator is making the compiler's type prediction to fail.

TS compiler works for simple logic like doing typeof var === "string" and then using it as string, the compiler infers it to be a string even if the type was string | boolean ...other types.

maybe add a interface for this if it's possible

evenstensberg · 2018-06-28T15:32:57Z

packages/generators/add-generator.ts

 				if (action === "resolveLoader") {
 					action = "resolve";
 				}
-				const webpackSchemaProp = webpackSchema.definitions[action];
+				const webpackSchemaProp: any = webpackSchema.definitions[action];


avoid using any here, just check the prop instead

evenstensberg · 2018-06-28T15:39:05Z

packages/generators/types/yeoman-generator.d.ts

+        emit(event: string, ...args: any[]): boolean;
+        listenerCount(type: string): number;
+
+        async(): any;


async is probably a promise

evenstensberg · 2018-06-28T15:39:26Z

packages/generators/types/yeoman-generator.d.ts

+        prompt(opt: IPromptOptions | IPromptOptions[], callback: (answers: any) => void): void;
+        prompt<T>(opt: IPromptOptions | IPromptOptions[]): PromiseLike<T>;
+        log(message: string) : void;
+        npmInstall(packages: string[], options?: any, cb?: Function): any;


this is not any

evenstensberg · 2018-06-28T15:39:33Z

packages/generators/types/yeoman-generator.d.ts

+
+        appname: string;
+        gruntfile: IGruntFileStatic;
+        options: { [key: string]: any };


not any here

evenstensberg · 2018-06-28T15:39:56Z

packages/generators/types/yeoman-generator.d.ts

+        choices?: any[] | ((answers: Object) => any);
+        default?: string | number | string[] | number[] | ((answers: Object) => (string | number | string[] | number[]));
+        validate?: ((input: any) => boolean | string);
+        filter?: ((input: any) => any);


insecure about the use of any here

evenstensberg · 2018-06-28T15:40:10Z

packages/generators/types/yeoman-generator.d.ts

+        registerTask(name:string, tasks:any):void;
+        insertVariable(name:string, value:any):void;
+        prependJavaScript(code:string):void;
+    }


these any values should be more type specific

ematipico · 2018-06-28T15:54:29Z

Please update the template with the relevant information and link this PR to the original issue

webpack-bot · 2018-06-29T12:05:40Z

@dhruvdutt Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

evenstensberg

Could you rebase and I'll have another look?

evenstensberg · 2018-07-01T03:32:25Z

packages/generators/remove-generator.js

+            configPath = null;
+            // end the generator stating webpack config not found or to specify the config
+        }
+        this.webpackOptions = require(configPath);


you'll need to do a json read on this, require's will try to resolve dependencies, which we don't need to install in order to run the ast transformation

evenstensberg · 2018-07-01T03:33:52Z

packages/generators/remove-generator.ts

+					this.configuration.config.webpackOptions[propType] = null;
+				}
+			})
+			.then(() => {


void here _: void

evenstensberg · 2018-07-01T03:34:27Z

packages/generators/remove-generator.ts

+	}
+
+	public prompting() {
+		const done: () => void | boolean = this.async();


If you do that then we'll have to pass something when we call done() at the end of generators.

oh okay, let's keep it then (:

evenstensberg · 2018-07-01T03:34:58Z

packages/generators/types/json-loader.d.ts

@@ -0,0 +1,4 @@
+declare module "*.json" {
+	const value: any;


this is not any, bool | num | object | array

Actually, we have to use any here else it won't be able to read the json file. This is just json-loader because TS doesn't have inbuilt support for importing .json files.
We've defined types while assigning / using json values.

https://github.com/dhruvdutt/webpack-cli/blob/3a711035c0178ab2f7b97e7b3cd3b7d47972a98b/packages/generators/add-generator.ts#L167

CC @TheLarkInn

evenstensberg · 2018-07-01T03:35:42Z

packages/generators/utils/entry.ts

+ * @returns	{Object} An Object that holds the answers given by the user, later used to scaffold
+ */
+
+export default function entry(self: any, answer: {


generator instance on self

As types don't get carried forward in functions, we had to define an explicit interface for Yeoman which could be used here. So, added IYeoman.

evenstensberg · 2018-07-01T03:36:08Z

packages/generators/utils/entry.ts

+				const webpackEntryPoint: object = {};
+				entryIdentifiers = multipleEntriesAnswer.multipleEntries.split(",");
+
+				function forEachPromise(entries, fn) {


missing types

evenstensberg · 2018-07-01T03:36:41Z

packages/generators/utils/module.ts

+	loader: string;
+	options: {
+		plugins: string[];
+		presets: any[];


evenstensberg · 2018-07-01T03:38:01Z

packages/webpack-scaffold/index.ts

@@ -11,7 +11,7 @@ interface IInquirerList extends IScaffoldBaseObject {
 }

 interface IInquirerInput extends IScaffoldBaseObject {
-	validate?: Function;
+	validate?: (input: any) => string | boolean;


input is string

evenstensberg · 2018-07-01T03:38:12Z

packages/webpack-scaffold/index.ts

@@ -95,7 +95,7 @@ export function Input(name: string, message: string): IInquirerInput {
 	};
 }

-export function InputValidate(name: string, message: string, cb: Function): IInquirerInput {
+export function InputValidate(name: string, message: string, cb?: (input: any) => string | boolean): IInquirerInput {


input is string

evenstensberg · 2018-07-01T03:39:07Z

packages/generators/types/yeoman-generator.d.ts

+		message: string | ((answers: Object) => string);
+		choices?: any[] | ((answers: Object) => any);
+		default?: string | number | string[] | number[] | ((answers: Object) => (string | number | string[] | number[]));
+		validate?: ((input: any) => boolean | string);


string as input

webpack-bot · 2018-07-05T21:43:24Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

evenstensberg · 2018-07-06T05:31:14Z

packages/generators/addon-generator.ts

-	copyTemplateFiles,
-	templateFn
+export default function addonGenerator(
+	prompts: any[],


My bet is that these are array of functions or promises, debug it to check

evenstensberg · 2018-07-06T05:32:17Z

packages/generators/init-generator.ts

 			);
 		}
-		const packager = getPackageManager();
+		const packager: string = getPackageManager();
 		const opts = packager === "yarn" ? { dev: true } : { "save-dev": true };


missing type

evenstensberg · 2018-07-06T05:33:10Z

packages/generators/remove-generator.ts

+			configPath = null;
+			// end the generator stating webpack config not found or to specify the config
+		}
+		this.webpackOptions = fs.readFileSync(configPath, "utf8");


I think you'll need to do a JSON parse too, this will be a utf8 encoded string

Yeah. This will return a string. Doing JSON.parse() on that string would result in error because the string contents aren't in JSON convertable format as it would be module.exports = { ... }. Even if we somehow read it in some JS variable, we would have to read object at module.exports.

I think the best way is to do require(configPath). Same as we were doing earlier. It would directly read the webpack config object present at module.export = { ... }.

We should always use require because the file we are reading is a node module.

Yes you are right on the part on requiring the correct module, but when we do a require it will try to resolve dependencies we might not have in the repo and access variables that we might not need to bother with. It will result in a lot of errors for us and that's not good.

Try to implement this using a JSON read instead. It is fully possible. To access the variables you'll need to do something like module['entry'] etc

it will try to resolve dependencies we might not have in the repo.

require doesn't always / only resolve npm dependencies. It's also a standard convention for importing modules. If it's a file path like in this case, it won't try to resolve dependencies but simply import the module.exports object.

It will result in a lot of errors for us and that's not good.

We were already using this convention in the existing codebase (master).

webpack-cli/packages/utils/modify-config-helper.js

Line 71 in 617af0b

configModule = require(configPath);

webpack-cli/packages/generators/add-generator.js

Line 326 in 617af0b

? require(resolvePluginsPath)

Can we have some third opinion @ematipico ?

In that case, it should be changed. @dhruvdutt either way you do this, make sure not to import a file directly, as it would resolve the dependencies. I assume the closest thing you'll get to a error-free case is a stringified and parsed json

evenstensberg · 2018-07-06T05:34:33Z

packages/generators/types/index.ts

+	type?: string;
+}
+
+export interface IWebpackOptions {


These types need to be written as they will be, all of them are strings in the ast types, but here they are specified. Check webpack validation schema for definition of types

You mean everything from this file?

Yes that's right

Base your values on that file, avoid using any

evenstensberg · 2018-07-06T05:34:55Z

packages/generators/types/json-loader.d.ts

@@ -0,0 +1,4 @@
+declare module "*.json" {
+	const value: any;


CC @TheLarkInn

evenstensberg · 2018-07-06T05:35:18Z

packages/generators/types/yeoman-generator.d.ts

+	public run(target: string, options?: object, done?: Function): IRunEnv;
+	public runInstall(packager: string, dependencies: string[], options?: object): void;
+	public on(event: string, listener: Function): this;
+	public async(): () => void | boolean;


is _? void possible here?

evenstensberg · 2018-07-06T05:35:36Z

packages/generators/types/yeoman-generator.d.ts

+		public run(target: string, options?: object, done?: Function): IRunEnv;
+		public runInstall(packager: string, dependencies: string[], options?: object): void;
+		public on(event: string, listener: Function): this;
+		public async(): () => void | boolean;


is _?:void possible here?

evenstensberg · 2018-07-06T05:36:31Z

tslint.json

@@ -15,6 +15,10 @@
      ],
      "no-console": {
        "severity": "warning"
+      },
+      "max-line-length": {
+        "options": { "limit": 120 },


let's keep this to 70 and warn when it's over limit

evenstensberg · 2018-07-07T09:10:41Z

Needs a rebase :)

evenstensberg

PTAL

evenstensberg · 2018-07-10T03:47:50Z

.gitignore

@@ -33,6 +33,3 @@ lerna-debug.log

 # Yarn lock file
 yarn.lock
-
-# Custom typings


Missing types folder

We decided to remove types from root level and move it inside packages. Removing it from gitignore was left.

evenstensberg · 2018-07-10T03:49:19Z

packages/generators/remove-generator.ts

 		])
-			.then(({ propType }) => {
+			.then(({ propType }: { propType: string }) => {


returns promise

evenstensberg · 2018-07-10T03:49:31Z

packages/generators/remove-generator.ts

-						]).then(({ keyType }) => {
+								Array.from(propValue),
+							),
+						]).then(({ keyType }: { keyType: string }) => {


returns promise

We aren't returning anything inside this block. It should be void.

evenstensberg · 2018-07-10T03:49:39Z

packages/generators/remove-generator.ts

 						])
-							.then(({ keyType }) => {
+							.then(({ keyType }: { keyType: string }) => {


returns promise

evenstensberg · 2018-07-10T03:49:49Z

packages/generators/remove-generator.ts

-											this.configuration.config.webpackOptions.module = {
-												rules: [ loader ]
-											};
+										.then(({ rule }: { rule: string }) => {


returns promise

We aren't returning anything inside this block. It should be void.

evenstensberg · 2018-07-10T03:51:06Z

packages/generators/utils/entry.ts

+						),
+					]),
+				).then((entryPropAnswer: object) => {
+					Object.keys(entryPropAnswer).forEach((val: string) => {


returns void

evenstensberg · 2018-07-10T03:51:12Z

packages/generators/utils/entry.ts

+							validate,
+						),
+					]),
+				).then((entryPropAnswer: object) => {


returns promise

It's actually returning the entryPropAnswer itself / webpackEntryPoint which is an object.

evenstensberg · 2018-07-10T03:51:20Z

packages/generators/utils/entry.ts

-			.then(singularEntryAnswer => {
+			.then((singularEntryAnswer: {
+				singularEntry: string,
+			}) => {


returns promise

It's actually returning the singularEntry itself which is a string.

Every promise returns a promise https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/then

Take a look at this code (from master) where we are returning non-Promise / string.

webpack-cli/packages/generators/utils/entry.js

Lines 88 to 97 in 617af0b

.then(singularEntryAnswer => {

let { singularEntry } = singularEntryAnswer;

if (singularEntry.indexOf("\"") >= 0) {

singularEntry = singularEntry.replace(/"/g, "'");

}

if (singularEntry.length <= 0) {

self.usingDefaults = true;

}

return singularEntry;

});

There are many such examples where we aren't returning Promise. What should we do in such cases?

I think there's some confusion here. The .then returns a promise but the actual callback called inside the .then returns whatever we want.

So if we have

Const p = promise.then(_ => 5)

p is of the type Promise<Number> and the callback returns a type of Number.

To clarify, the callback doesn't return a promise

Okay. Emanuelle cleared it out. Add types for those though ;)

evenstensberg · 2018-07-10T03:51:47Z

packages/generators/utils/plugins.ts

 * @returns {Function} An function that returns an array
 * that consists of the uglify plugin
 */

-module.exports = _ => {
+export default function(): string[] {


(_?:void)

It's not a promise, so _ should be removed. Can we have a eslint rule?

_ on empty params please http://po-ru.com/diary/rubys-magic-underscore/

That's Ruby, that treats them differently, what's your point?
Also, underscore is used as temporary placeholder in libraries such as Ramda, where it has a different meaning. My point is, what's the heff meaning of this underscore in this project? Where's documented? Why there's no eslint rule to tell me that the developer has to put in certain cases?

Responded this internally. Needs an issue to be in the desc of the update docs issue

evenstensberg · 2018-07-10T03:52:14Z

packages/webpack-scaffold/index.ts

 	name: string;
 	message: string;
+	choices?: ((answers: Object) => any) | any[];


returns array of strings

evenstensberg · 2018-07-13T04:49:57Z

packages/generators/add-generator.ts

-	arr.forEach(p => {
+const traverseAndGetProperties = (arr: object[], prop: string): boolean => {
+	let hasProp: boolean = false;
+	arr.forEach((p: object) => {


returns void

evenstensberg · 2018-07-13T04:50:07Z

packages/generators/add-generator.ts

-		PROPS.filter(food =>
-			food.toLowerCase().includes(input.toLowerCase())
-		)
+		PROPS.filter((prop: string) =>


missing ret type for filter

evenstensberg · 2018-07-13T04:51:18Z

packages/generators/add-generator.ts

 						// Array -> Object -> Merge objects into one for compat in manualOrListInput
 						defOrPropDescription = Object.keys(defOrPropDescription[0].enum)
-							.map(p => {
+							.map((p: string) => {


missing ret on map

evenstensberg · 2018-07-13T04:51:31Z

packages/generators/add-generator.ts

 								);
 							})
-							.reduce((result, currentObject) => {
-								for (let key in currentObject) {
+							.reduce((result: object, currentObject: object) => {


missing return for reduce

evenstensberg · 2018-07-13T04:51:53Z

packages/generators/add-generator.ts

 						])
-						.map(p =>
+						.map((p: string) =>


map missing return

evenstensberg · 2018-07-13T04:54:38Z

packages/generators/plugin-generator.ts

 	],
 	["src/_index.js.tpl", "examples/simple/_webpack.config.js.tpl"],
-	gen => ({ name: _.upperFirst(_.camelCase(gen.props.name)) })
+	(gen: IYeoman) => ({ name: _.upperFirst(_.camelCase(gen.props.name)) }),


missing return type

evenstensberg · 2018-07-13T04:55:12Z

packages/generators/remove-generator.ts

+			if (this.webpackOptions.module && this.webpackOptions.module.rules) {
+				return this.webpackOptions.module.rules.map((rule: {
+					loader: string;
+				}) => rule ? rule.loader : null);


missing ret type

Type is already present as an object.

evenstensberg · 2018-07-13T04:56:10Z

packages/generators/utils/entry.ts

 							if (n) {
-								Object.keys(n).forEach(val => {
+								Object.keys(n).forEach((val: string) => {


missing return type

evenstensberg · 2018-07-13T04:56:46Z

packages/generators/utils/module.ts

+ * @returns {Function} A callable function that adds the babel-loader with env preset
+ */
+export default function(): IModule {
+	return {


returns obj

Yeah! interface IModule extends Object :)

evenstensberg · 2018-07-13T04:57:05Z

packages/generators/utils/validate.ts

@@ -8,10 +6,10 @@
 * @returns {String | Boolean } Returns truthy if its long enough
 * Or a string if the user hasn't written anything
 */
-module.exports = value => {
+export default function validate(value: string): string | boolean {
 	const pass = value.length;


missing type on const

evenstensberg

lgtm

webpack-bot added the PR: unreviewed label Jun 27, 2018

dhruvdutt force-pushed the typescript-generators branch from 6b75f73 to 5d85a72 Compare June 28, 2018 14:33

evenstensberg requested changes Jun 28, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Jun 28, 2018

dhruvdutt force-pushed the typescript-generators branch from 5d85a72 to 97c62f7 Compare June 29, 2018 12:05

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Jun 29, 2018

webpack-bot added PR: CI-not-ok PR: conflict and removed PR: CI-not-ok labels Jun 29, 2018

evenstensberg requested changes Jun 30, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Jun 30, 2018

dhruvdutt force-pushed the typescript-generators branch from 97c62f7 to 4561b57 Compare June 30, 2018 13:46

webpack-bot added PR: review-outdated PR: CI-ok and removed PR: conflict PR: reviewed-changes-requested labels Jun 30, 2018

dhruvdutt changed the title ~~[WIP] - feat(generators): add typescript support~~ feat(generators): add typescript support Jun 30, 2018

dhruvdutt force-pushed the typescript-generators branch from 4561b57 to 5ac0f2b Compare June 30, 2018 18:51

evenstensberg reviewed Jul 1, 2018

View reviewed changes

evenstensberg requested changes Jul 1, 2018

View reviewed changes

webpack-bot removed the PR: review-outdated label Jul 1, 2018

evenstensberg requested changes Jul 6, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Jul 6, 2018

dhruvdutt force-pushed the typescript-generators branch from 0523834 to 67916d9 Compare July 6, 2018 12:28

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Jul 6, 2018

dhruvdutt force-pushed the typescript-generators branch from 67916d9 to fddd317 Compare July 6, 2018 12:31

evenstensberg requested changes Jul 10, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Jul 10, 2018

feat(generators): add typescript support

572df45

dhruvdutt force-pushed the typescript-generators branch from d001aff to 06de9e0 Compare July 10, 2018 08:24

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Jul 10, 2018

dhruvdutt force-pushed the typescript-generators branch from 06de9e0 to d7fc352 Compare July 10, 2018 08:28

evenstensberg requested changes Jul 13, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Jul 13, 2018

dhruvdutt force-pushed the typescript-generators branch from d7fc352 to 7dad2d4 Compare July 13, 2018 07:40

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Jul 13, 2018

feat(types): add webpack types schema

75f018e

dhruvdutt force-pushed the typescript-generators branch from 7dad2d4 to 75f018e Compare July 13, 2018 07:42

evenstensberg approved these changes Jul 13, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Jul 13, 2018

dhruvdutt merged commit 90909e4 into webpack:next Jul 13, 2018

snyk-bot mentioned this pull request Sep 12, 2021

[Snyk] Fix for 1 vulnerabilities enterstudio/webpack-cli#20

Open

	.then(singularEntryAnswer => {
	let { singularEntry } = singularEntryAnswer;
	if (singularEntry.indexOf("\"") >= 0) {
	singularEntry = singularEntry.replace(/"/g, "'");
	}
	if (singularEntry.length <= 0) {
	self.usingDefaults = true;
	}
	return singularEntry;
	});

feat(generators): add typescript support #532

feat(generators): add typescript support #532

Conversation

dhruvdutt commented Jun 27, 2018 • edited Loading

evenstensberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ematipico commented Jun 28, 2018

webpack-bot commented Jun 29, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webpack-bot commented Jul 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhruvdutt Jul 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evenstensberg commented Jul 7, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhruvdutt commented Jun 27, 2018 •

edited

Loading

dhruvdutt Jul 6, 2018 •

edited

Loading