Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor bin folder #527

Merged
merged 84 commits into from
Dec 25, 2018
Merged

[WIP] Refactor bin folder #527

merged 84 commits into from
Dec 25, 2018

Conversation

evenstensberg
Copy link
Member

@evenstensberg evenstensberg commented Jun 25, 2018

  • Class based instances for packages

  • Set up structure

  • Use logger module

  • Flags are validated correctly

  • Flags are grouped

  •  Better abstraction level for adapter layer

  • Flags are converted to their respective properties mapped to an webpackOptions object

  • Hook up logic with compilation

  • 0CJS story experiment on next branch

  • interactive command

  • extend option

  • fill options

@ematipico
Copy link
Contributor

Could you please fill the issue description with the relevant information of what this is PR for, why, etc.?
Also, could you create an issue?

@evenstensberg
Copy link
Member Author

There's a couple of issues on this already. Read on general improvements tickets and the old PR that was submitted on this. It's work in progress :)

@ematipico
Copy link
Contributor

ematipico commented Jun 28, 2018

Yes, I know. But for clarity and transparency we want to fill the whole template to give information to the community. Please fill the template with relevant information

EDIT: typo

@shellscape
Copy link

shellscape commented Jul 1, 2018

Please be mindful not to wholesale copy elements of structure and/or content from webpack-command. The recent 3ced7e5 commit adds files to 'lib/gorups that exactly match lib/flags in webpack-command.

@webpack-bot
Copy link

@evenstensberg The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from travis (failure) and fix these issues.

@evenstensberg evenstensberg changed the base branch from master to next December 25, 2018 21:20
@evenstensberg evenstensberg merged commit 737dd19 into next Dec 25, 2018
@evenstensberg evenstensberg deleted the refactor-bin-folder branch December 25, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants