Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] docs(pkg): readme file for add package #498

Merged
merged 2 commits into from
Jul 14, 2018
Merged

Conversation

ematipico
Copy link
Contributor

What kind of change does this PR introduce?
Documentation. Part of #247

Did you add tests for your changes?
No
If relevant, did you update the documentation?
yes
Summary
Created read me file for add sub package

Does this PR introduce a breaking change?
No


```bash
webpack add
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a screenshot would be good, as well as using it programatically. Could you do the same for the info pkg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I also wonder if there's need of more information inside the description?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things like a screenshot, what we're asking for etc.. would be nice

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update on this?

Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change base branch to next? Having master ahead of next would cause next to rebase and force push every time master gets ahead.

@evenstensberg
Copy link
Member

@ematipico any update?

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ematipico look at your merged PR for what's left on this. lowercase on "add" and some missing sections

@evenstensberg evenstensberg changed the base branch from master to next July 14, 2018 10:44
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signing this of. lgtm :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants