[WIP] docs(pkg): readme file for add package #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/add/README.md
Outdated
|
|
||
| ```bash | ||
| webpack add | ||
| ``` |
There was a problem hiding this comment.
Maybe a screenshot would be good, as well as using it programatically. Could you do the same for the info pkg?
There was a problem hiding this comment.
Yes! I also wonder if there's need of more information inside the description?
There was a problem hiding this comment.
Some things like a screenshot, what we're asking for etc.. would be nice
dhruvdutt
reviewed
Jun 15, 2018
|
@ematipico any update? |
evenstensberg
requested changes
Jul 8, 2018
There was a problem hiding this comment.
@ematipico look at your merged PR for what's left on this. lowercase on "add" and some missing sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Documentation. Part of #247
Did you add tests for your changes?
No
If relevant, did you update the documentation?
yes
Summary
Created read me file for add sub package
Does this PR introduce a breaking change?
No