Update UglifyJSPlugin transformation #401

matheus1lva · 2018-04-12T12:27:22Z

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
Yes.
Tests included to test scenarios where:

User was using webpack.optimize.UglifyJsPlugin without custom options
User was using webpack.optimize.UglifyJsPlugin with custom options
User was using uglify-webpack-plugin with custom options
User was using uglify-webpack-plugin without custom options

Summary
Fix #389

Does this PR introduce a breaking change?
Yes. It deprecates migration from v1->v2 and only supports v3->v4

matheus1lva · 2018-04-12T12:31:03Z

lib/migrate/uglifyJsPlugin/__snapshots__/uglifyJsPlugin.test.js.snap

@@ -2,36 +2,110 @@

 exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-0" data 1`] = `
 "module.exports = {
-    plugins: [
-        new webpack.optimize.UglifyJsPlugin({


I found a problem here, something i left behind... i'm fixing it now.

evenstensberg · 2018-04-13T08:27:37Z

lib/migrate/uglifyJsPlugin/uglifyJsPlugin.js

+		.filter(j.filters.VariableDeclarator.requiresModule("uglifyjs-webpack-plugin"));
+
+	// Look for a variable declaration which requires uglifyjs-webpack-plugin
+	// saves the name of this variable.


Multi line comment here

evenstensberg · 2018-04-13T08:27:46Z

lib/migrate/uglifyJsPlugin/uglifyJsPlugin.js

+		// options passed to plugin
+		const pluginOptions = node.value.arguments;
+
+		// check if there are any options passed to UglifyWebpackPlugin


ML comment.

evenstensberg · 2018-04-13T08:27:58Z

lib/migrate/uglifyJsPlugin/uglifyJsPlugin.js

+		// If user is using UglifyJsPlugin directly from webpack
+		// transformation must:
+		// - remove it
+		// - add require for uglify-webpack-plugin


evenstensberg · 2018-04-13T08:29:31Z

lib/migrate/uglifyJsPlugin/__snapshots__/uglifyJsPlugin.test.js.snap

-            sourceMap: true
-        })
-    ]
+    plugins: [],


Why's this empty? Should be preserved when uglifyJSPlugin is correct?

I missed this cleanup. I'm going to create an utility to remove plugins property if they are empty, so it can be used by other transformations that fell into the same problem.

webpack-bot · 2018-04-13T14:15:18Z

@playma256 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

matheus1lva · 2018-04-13T14:59:45Z

I'm adding tests to this new method. I just messed up a bit, i'm fixing them.

evenstensberg · 2018-04-14T17:00:12Z

lib/utils/__snapshots__/ast-utils.test.js.snap

@@ -90,6 +90,22 @@ exports[`utils createProperty should create properties for non-literal keys 1`]
 }"
 `;

+exports[`utils findPluginsArrayAndRemoveIfEmpty should not remove plugins property, since it has length > 0 1`] = `


Use proper grammar here.

evenstensberg · 2018-04-14T17:03:40Z

lib/utils/ast-utils.js

+ * remove if it has no elements.
+ * @param  {any} j - jscodeshift API
+ * @param  {Node} rootNode - node to start search from
+ */


Missing jsdoc for return here

It lookouts for the plugins property and, the array is empty, it removes it from the AST

evenstensberg · 2018-04-14T17:05:30Z

lib/migrate/uglifyJsPlugin/__snapshots__/uglifyJsPlugin.test.js.snap

+    optimization: {
+        minimize: true,
+
+        minimizer: [new UglifyJsPlugin({


Is this correct? Could you link me to the docs on this?

https://github.com/webpack/webpack/blob/master/test/configCases/plugins/uglifyjs-plugin/webpack.config.js#L20

Yes it is

Oki, good stuff

matheus1lva · 2018-04-15T15:15:33Z

All the small fixes which were required are done!

…uration

…glifyPlugin

Created function on ast-utils so every other transformation can use this.

webpack-bot · 2018-04-15T15:33:55Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

matheus1lva · 2018-04-23T18:16:58Z

I was looking at this, to tell my workmates that they could use to upgrade the webpack config on their projects, but i was not able to see my commits on the uglifyjs migration, it seems to be in its original state (v1->v2).

What happened (@ematipico @ev1stensberg )?

webpack-bot added the PR: unreviewed label Apr 12, 2018

matheus1lva commented Apr 12, 2018

View reviewed changes

webpack-bot added PR: CI-not-ok PR: CI-ok and removed PR: CI-not-ok labels Apr 12, 2018

matheus1lva mentioned this pull request Apr 12, 2018

Update transformation: removeDeprecatedPlugins #386

Closed

evenstensberg requested changes Apr 13, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Apr 13, 2018

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Apr 13, 2018

matheus1lva mentioned this pull request Apr 13, 2018

Add NoEmitOnErrorsPlugin transformation #399

Merged

evenstensberg requested changes Apr 14, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Apr 14, 2018

evenstensberg reviewed Apr 14, 2018

View reviewed changes

evenstensberg approved these changes Apr 15, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Apr 15, 2018

webpack-bot added PR: CI-not-ok and removed PR: CI-ok labels Apr 15, 2018

matheus1lva added 3 commits April 15, 2018 15:26

cli(migration): Update UglifyJS migration file to fit webpack4 config…

12613d6

…uration

cli(migration): Add cases where require variable does not need to exist

1bbcc01

cli(migration): Add transformation for usage of webpack.otimization.U…

ebb4fa5

…glifyPlugin

matheus1lva added 6 commits April 15, 2018 15:26

cli(tests): Update test snapshots after updating transformation

8b6522e

cli(fix): fix expressionContent being null

74034bf

cli(refactor): remove plugins array if empty

5dded3f

Created function on ast-utils so every other transformation can use this.

tests: add tests for new ast-utils method

f8c06c8

fix: fix test names and jsdoc

c4a05a3

fix: update maxSize for utils folder

afe9c9a

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Apr 15, 2018

dhruvdutt approved these changes Apr 15, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Apr 15, 2018

ematipico added the Semver: minor ⚙️ When delivering new features that don't break label Apr 16, 2018

ematipico approved these changes Apr 18, 2018

View reviewed changes

evenstensberg merged commit 65c46e0 into webpack:master Apr 18, 2018

matheus1lva deleted the feature/v3-v4-uglifyJs branch April 18, 2018 12:22

matheus1lva restored the feature/v3-v4-uglifyJs branch April 23, 2018 18:07

matheus1lva mentioned this pull request Apr 23, 2018

Update UglifyJS transformation #416

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update UglifyJSPlugin transformation #401

Update UglifyJSPlugin transformation #401

matheus1lva commented Apr 12, 2018

matheus1lva Apr 12, 2018

matheus1lva Apr 12, 2018

evenstensberg Apr 13, 2018

evenstensberg Apr 13, 2018

evenstensberg Apr 13, 2018

evenstensberg Apr 13, 2018

matheus1lva Apr 13, 2018

webpack-bot commented Apr 13, 2018

matheus1lva commented Apr 13, 2018

evenstensberg Apr 14, 2018

evenstensberg Apr 14, 2018

ematipico Apr 15, 2018

evenstensberg Apr 14, 2018

ematipico Apr 15, 2018 •

edited

Loading

evenstensberg Apr 15, 2018

matheus1lva commented Apr 15, 2018

webpack-bot commented Apr 15, 2018

matheus1lva commented Apr 23, 2018 •

edited

Loading

Update UglifyJSPlugin transformation #401

Update UglifyJSPlugin transformation #401

Conversation

matheus1lva commented Apr 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webpack-bot commented Apr 13, 2018

matheus1lva commented Apr 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ematipico Apr 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matheus1lva commented Apr 15, 2018

webpack-bot commented Apr 15, 2018

matheus1lva commented Apr 23, 2018 • edited Loading

ematipico Apr 15, 2018 •

edited

Loading

matheus1lva commented Apr 23, 2018 •

edited

Loading