Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no serve when dev-server is false #2947

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Conversation

rishabh3112
Copy link
Member

@rishabh3112 rishabh3112 commented Sep 13, 2021

What kind of change does this PR introduce?
Fix

Did you add tests for your changes?
Yup

If relevant, did you update the documentation?
Yes

Summary
No dev server when devServer: false is supplied.

Does this PR introduce a breaking change?
Nope

Other information
/cc @alexander-akait

@rishabh3112 rishabh3112 requested a review from a team as a code owner September 13, 2021 08:11
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #2947 (c18b084) into master (bd661fb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
+ Coverage   90.87%   90.89%   +0.02%     
==========================================
  Files          22       22              
  Lines        1688     1692       +4     
  Branches      486      488       +2     
==========================================
+ Hits         1534     1538       +4     
  Misses        154      154              
Files Coverage Δ
packages/serve/src/index.ts 79.46% <ø> (ø)
packages/webpack-cli/src/webpack-cli.ts 92.63% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd661fb...c18b084. Read the comment docs.

@rishabh3112
Copy link
Member Author

@alexander-akait devServer is object in schema, should change/publish that first to support devServer: false.

@alexander-akait
Copy link
Member

We should return before using schema

@rishabh3112
Copy link
Member Author

We should return before using schema

We should not read configuration without validating against schema ideally.

@evenstensberg evenstensberg self-assigned this Nov 22, 2023
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests green. LGTM 🧑🏽‍💻

@evenstensberg evenstensberg merged commit a93e860 into master Nov 22, 2023
56 checks passed
@evenstensberg evenstensberg deleted the fix/dev-server-false branch November 22, 2023 21:26
@alexander-akait
Copy link
Member

We need to revert this, because we should not exit, just run a regular compilation with a warning, I will fix it

@alexander-akait
Copy link
Member

Also webpack build with devServer: false should work too without any problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants