-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no serve when dev-server is false #2947
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
+ Coverage 90.87% 90.89% +0.02%
==========================================
Files 22 22
Lines 1688 1692 +4
Branches 486 488 +2
==========================================
+ Hits 1534 1538 +4
Misses 154 154
Continue to review full report in Codecov by Sentry.
|
@alexander-akait devServer is |
We should return before using schema |
We should not read configuration without validating against schema ideally. |
0b5cc63
to
6d93622
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests green. LGTM 🧑🏽💻
We need to revert this, because we should not exit, just run a regular compilation with a warning, I will fix it |
Also |
What kind of change does this PR introduce?
Fix
Did you add tests for your changes?
Yup
If relevant, did you update the documentation?
Yes
Summary
No dev server when
devServer: false
is supplied.Does this PR introduce a breaking change?
Nope
Other information
/cc @alexander-akait