fix: yeoman-generator fork issue

[dhruvdutt]

What kind of change does this PR introduce?

Fixes the issue with yeoman-generator fork. Fixes #291 🐛

• Update yeoman-generator module path in package.json to match the syntax recommended by npm.
• Change the module name and usage from "webpack-fork-yeoman-generator" to "yeoman-generator" across all files.

Tests

All tests pass. 💯 Also, did a quick test with:

mkdir test-dir && cd test-dir;
mkdir src && touch src/index.js;
webpack-cli init

(Update): Added a temp eslint-disable-line to pass CI. For more description check comments.

Summary

Also, now we don't need to published the fork separately.

Related commit (0b4269c)

Does this PR introduce a breaking change?
No

[dhruvdutt]

(Update): Added a temp eslint-disable-line to pass CI.

The issue is with how prettier formats and writes our code which later eslint lints.

When yarn format runs, prettier tries to indent and adds an extra space (highlighted in screenshot) which causes yarn lint to fail throwing no-mixed-spaces-and-tabs

I think we did not catch this earlier because these files were not being changed and hence prettier or eslint might be skipping them while checks but this PR contains change in those files.

I also tried using --use-tabs flag with prettier-eslint-cli command as suggested in their docs but it resulted in the same issue.

[justerest]

it fixs #291

[evenstensberg]

Remove the eslint disables, and I can LGTM

[evenstensberg]

• discard changes to any other module, you can do a force push with lease without precomitting

[dhruvdutt]

@ev1stensberg Updated. 💯

[evenstensberg]

Okay nice, so you can reimpl the disables, weird they weren't throwing earlier

[webpack-bot]

@dhruvdutt Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

[montogeek]

@ev1stensberg Please apologies in advance, Why is yeoman necessary in this project? And also why a forked was needed?

[evenstensberg]

It's to grab arguments from a generator ( the config we're scaffolding ). The fork implements a way to do that, yeoman doesn't support it

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[montogeek]

Isn't it possible to implement it from scratch of using another library that supports it?
What it is exactly doing? Replacing values in templates and creating directory/files?

[evenstensberg]

Possibly, needs investigation anyhow :(

[LukeChannings]

@ev1stensberg

Is there a way to avoid the custom yeoman-generator dependency? I'm working in an environment that loads all dependencies through a Nexus repo and blocks github.com. The latest webpack-cli is not installable for me because of this.

[evenstensberg]

I'm having a lot to do until thursday +-, will try to get something up after that. We're gonna use yeoman, but not the fork. Right now, we avoid writing to a temp yeoman-rc file, and get the config from the generator instead. To fix this, we probably need to make a temp config and parse it ( sigh ).

[louisscruz]

The reliance on the custom yeoman-generator dependency brought me here. It ended up introducing some kind of invalid file to my offline-cache (mirror), so I had to roll back a version.