feat: added the watch command
#2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2357 +/- ##
==========================================
+ Coverage 69.47% 70.21% +0.73%
==========================================
Files 47 47
Lines 2110 2122 +12
Branches 541 547 +6
==========================================
+ Hits 1466 1490 +24
+ Misses 644 632 -12
Continue to review full report at Codecov.
|
alexander-akait
commented
Jan 15, 2021
| @@ -1373,6 +1396,7 @@ class WebpackCLI { | |||
| } | |||
|
|
|||
| if (options.json) { | |||
| const { stringifyStream: createJsonStringifyStream } = require('@discoveryjs/json-ext'); | |||
There was a problem hiding this comment.
Reduce time to initial run
Co-authored-by: James George <[email protected]>
This was referenced Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Many popular tools have the
watchcommand, let's do the same and we will have good built-in command:Does this PR introduce a breaking change?
No
Other information
After this I will focus on
webpack index.js, after refactor we can return this again, but with some limitations, I will describe them in the PR