fix: correct usage of cli-flags #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
force-pushed
the
fix/multiple-usage
branch
from
70f0b4b
to
7b87c61
Compare
alexander-akait
approved these changes
Dec 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #2205 +/- ##
=======================================
Coverage 68.19% 68.19%
=======================================
Files 70 70
Lines 2352 2352
Branches 523 523
=======================================
Hits 1604 1604
Misses 748 748
Continue to review full report at Codecov.
|
jamesgeorge007
approved these changes
Dec 7, 2020
anshumanv
reviewed
Dec 7, 2020
| @@ -114,7 +114,7 @@ const builtInFlags = [ | |||
| // Complex configs | |||
| { | |||
| name: 'env', | |||
| usage: '--env', | |||
| usage: '--env <variable> | --env <variable> --env <variable=value>', | |||
There was a problem hiding this comment.
Ah I think we should also mention that we support nested flags here, var1.var2.var3=value, will PR
/cc @alexander-akait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
correct usage of cli-flags
Does this PR introduce a breaking change?
No
Other information
No