Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct usage of cli-flags #2205

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
correct usage of cli-flags

Does this PR introduce a breaking change?
No

Other information
No

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #2205 (7b87c61) into master (53ed926) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2205   +/-   ##
=======================================
  Coverage   68.19%   68.19%           
=======================================
  Files          70       70           
  Lines        2352     2352           
  Branches      523      523           
=======================================
  Hits         1604     1604           
  Misses        748      748           
Impacted Files Coverage Δ
packages/webpack-cli/lib/utils/cli-flags.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5872d35...7b87c61. Read the comment docs.

@jamesgeorge007 jamesgeorge007 merged commit c8fc7d1 into master Dec 7, 2020
@jamesgeorge007 jamesgeorge007 deleted the fix/multiple-usage branch December 7, 2020 17:38
@@ -114,7 +114,7 @@ const builtInFlags = [
// Complex configs
{
name: 'env',
usage: '--env',
usage: '--env <variable> | --env <variable> --env <variable=value>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I think we should also mention that we support nested flags here, var1.var2.var3=value, will PR

/cc @alexander-akait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants