fix: respect stats from the config for webpack@4
#2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Nov 10, 2020
| @@ -641,11 +641,22 @@ class WebpackCLI { | |||
| process.exit(2); | |||
| } | |||
| } else { | |||
| logger.raw(`${stats.toString(foundStats)}`); | |||
| const printedStats = stats.toString(foundStats); | |||
There was a problem hiding this comment.
When we use stats: 'none' we have empty string, so no need to log empty string
anshumanv
reviewed
Nov 10, 2020
Co-authored-by: Anshuman Verma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2098 +/- ##
==========================================
+ Coverage 68.49% 68.54% +0.05%
==========================================
Files 75 75
Lines 2390 2394 +4
Branches 496 498 +2
==========================================
+ Hits 1637 1641 +4
Misses 753 753
Continue to review full report at Codecov.
|
|
lets fix CI |
|
Fixed |
|
Windows 😞 |
snitin315
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
fixes #2052
Does this PR introduce a breaking change?
No
Other information
webpack@4 doesn't return
compierwhenwatch: truein the config, fixed in webpack@5