Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect stats from the config for webpack@4 #2098

Merged
merged 6 commits into from
Nov 11, 2020
Merged

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

No

Summary

fixes #2052

Does this PR introduce a breaking change?

No

Other information

webpack@4 doesn't return compier when watch: true in the config, fixed in webpack@5

@@ -641,11 +641,22 @@ class WebpackCLI {
process.exit(2);
}
} else {
logger.raw(`${stats.toString(foundStats)}`);
const printedStats = stats.toString(foundStats);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we use stats: 'none' we have empty string, so no need to log empty string

Co-authored-by: Anshuman Verma <[email protected]>
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #2098 (f934054) into master (363f120) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2098      +/-   ##
==========================================
+ Coverage   68.49%   68.54%   +0.05%     
==========================================
  Files          75       75              
  Lines        2390     2394       +4     
  Branches      496      498       +2     
==========================================
+ Hits         1637     1641       +4     
  Misses        753      753              
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 93.58% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363f120...f934054. Read the comment docs.

@anshumanv
Copy link
Member

lets fix CI

@alexander-akait
Copy link
Member Author

Fixed

@snitin315
Copy link
Member

Windows 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats option is not respected in watch mode in 4.2.0
5 participants