Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose config resolving as CLI instance #2066

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
feat

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary
Expose config resolving on CLI instance for architecture

Does this PR introduce a breaking change?
No

Other information
/cc @evilebottnawi

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's migrate on async API everywhere

packages/webpack-cli/lib/webpack-cli.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #2066 (f4202d9) into master (6581ce9) will decrease coverage by 0.14%.
The diff coverage is 98.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2066      +/-   ##
==========================================
- Coverage   68.34%   68.19%   -0.15%     
==========================================
  Files          76       75       -1     
  Lines        2429     2418      -11     
  Branches      499      499              
==========================================
- Hits         1660     1649      -11     
  Misses        769      769              
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 92.92% <98.09%> (+2.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6581ce9...f4202d9. Read the comment docs.

alexander-akait
alexander-akait previously approved these changes Nov 9, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's do more improvements in future

@anshumanv
Copy link
Member Author

@evilebottnawi inlined the function here, need heavy refactor 😞 Will take care

@anshumanv anshumanv marked this pull request as ready for review November 9, 2020 18:50
@anshumanv anshumanv requested a review from a team as a code owner November 9, 2020 18:50
alexander-akait
alexander-akait previously approved these changes Nov 9, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's refactor it more in other PRs, I have couple ideas

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need rebase after #2092

snitin315
snitin315 previously approved these changes Nov 10, 2020
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rishabh3112
rishabh3112 previously approved these changes Nov 10, 2020
@anshumanv
Copy link
Member Author

very strange tests 😞

@anshumanv anshumanv merged commit 363f120 into webpack:master Nov 10, 2020
@anshumanv anshumanv deleted the conf-method branch November 10, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants