feat: expose config resolving as CLI instance #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
force-pushed
the
conf-method
branch
from
0be6565
to
711d394
Compare
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
- Coverage 68.34% 68.19% -0.15%
==========================================
Files 76 75 -1
Lines 2429 2418 -11
Branches 499 499
==========================================
- Hits 1660 1649 -11
Misses 769 769
Continue to review full report at Codecov.
|
anshumanv
force-pushed
the
conf-method
branch
from
711d394
to
ba67313
Compare
alexander-akait
previously approved these changes
Nov 9, 2020
|
@evilebottnawi inlined the function here, need heavy refactor 😞 Will take care |
alexander-akait
previously approved these changes
Nov 9, 2020
snitin315
reviewed
Nov 10, 2020
anshumanv
force-pushed
the
conf-method
branch
from
952fe22
to
aba80e2
Compare
alexander-akait
previously approved these changes
Nov 10, 2020
rishabh3112
previously approved these changes
Nov 10, 2020
anshumanv
dismissed stale reviews from rishabh3112, snitin315, and alexander-akait
via
f4202d9
anshumanv
force-pushed
the
conf-method
branch
from
aba80e2
to
f4202d9
Compare
alexander-akait
approved these changes
Nov 10, 2020
snitin315
approved these changes
Nov 10, 2020
|
very strange tests 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Expose config resolving on CLI instance for architecture
Does this PR introduce a breaking change?
No
Other information
/cc @evilebottnawi