Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assign config paths in build dependencies in cache config #1900

Merged
merged 10 commits into from
Oct 10, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
feat

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary
https://webpack.js.org/configuration/other-options/#cachebuilddependencies

  • After resolving core flags, assigns the configs as a build dep which is invalidated when configs change

Does this PR introduce a breaking change?
No

Other information

@anshumanv anshumanv requested a review from a team as a code owner October 9, 2020 07:42
@anshumanv anshumanv changed the title feat: assign config paths in build dependencies in config cache feat: assign config paths in build dependencies in cache config Oct 9, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

snitin315
snitin315 previously approved these changes Oct 10, 2020
@anshumanv anshumanv requested a review from a team October 10, 2020 14:12
@alexander-akait alexander-akait merged commit 7e90f11 into webpack:next Oct 10, 2020
@anshumanv anshumanv deleted the fix/cache branch October 10, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants