Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(remove code): remove unused code #1800

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Conversation

evenstensberg
Copy link
Member

What kind of change does this PR introduce?

Removes unused code

Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
Removes unused code.
Does this PR introduce a breaking change?
N/A
Other information
N/A

@evenstensberg
Copy link
Member Author

Could someone fix CI?

@snitin315
Copy link
Member

I will fix it 👍

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @snitin315 Do you work on it?

@snitin315
Copy link
Member

@evilebottnawi Yes here #1801 , one major issue is that help output is not working with [email protected] though its working fine with webpack@latest. See CI logs for more info.

@snitin315 snitin315 merged commit 4ee08d8 into next Sep 17, 2020
@snitin315 snitin315 deleted the enh/remove-unneeded-code branch September 17, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants