Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple targets #1799

Merged
merged 8 commits into from
Sep 17, 2020
Merged

feat: allow multiple targets #1799

merged 8 commits into from
Sep 17, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?

Feature

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?

Summary
webpack 5 now supports multiple targets. Allowing the support of multiple targets via CLI.

Does this PR introduce a breaking change?
No

Other information

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need fix CI 👍

@snitin315 snitin315 marked this pull request as ready for review September 17, 2020 01:56
@snitin315 snitin315 requested a review from a team as a code owner September 17, 2020 01:56
anshumanv
anshumanv previously approved these changes Sep 17, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snitin315 snitin315 merged commit 1724ddb into next Sep 17, 2020
@snitin315 snitin315 deleted the feat/multi-target branch September 17, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants