Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for merging multiple configurations #1768

Merged
merged 5 commits into from
Aug 26, 2020

Conversation

anshumanv
Copy link
Member

@anshumanv anshumanv commented Aug 25, 2020

What kind of change does this PR introduce?

feat/fix

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Yes

Summary

  • Merges all configurations together instead of single file
  • Merge flag is a boolean now
  • You can now do webpack -c 1.js -c 2.js -c 3.js --merge which was not possible before

Does this PR introduce a breaking change?
No

Other information
/cc @evilebottnawi

@anshumanv anshumanv marked this pull request as ready for review August 26, 2020 05:54
@anshumanv anshumanv requested a review from a team as a code owner August 26, 2020 05:54
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Left a few suggestions.

packages/webpack-cli/lib/utils/cli-flags.js Outdated Show resolved Hide resolved
packages/webpack-cli/lib/groups/ConfigGroup.js Outdated Show resolved Hide resolved
test/merge/config/merge-config.test.js Show resolved Hide resolved
@anshumanv anshumanv changed the title feat: convert merge flag to boolean feat: add support for merging multiple configurations Aug 26, 2020
@webpack-bot
Copy link

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants