-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for merging multiple configurations #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh3112
requested changes
Aug 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Left a few suggestions.
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
Aug 26, 2020
anshumanv
requested review from
rishabh3112 and
a team
and removed request for
rishabh3112
August 26, 2020 09:16
rishabh3112
approved these changes
Aug 26, 2020
alexander-akait
approved these changes
Aug 26, 2020
anshumanv
changed the title
feat: convert merge flag to boolean
feat: add support for merging multiple configurations
Aug 26, 2020
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
snitin315
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feat/fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
webpack -c 1.js -c 2.js -c 3.js --merge
which was not possible beforeDoes this PR introduce a breaking change?
No
Other information
/cc @evilebottnawi